Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration testing (file organization, time, memory) #664

Merged
merged 26 commits into from
Jan 8, 2025

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Dec 18, 2024

Usage related changes

None, hopefully.

Development related changes

  • Move integration tests into a separate crate tests/integration:
  • No more test modules within test files - all modules are in files of the same name.
  • Faster test execution.
  • Tests runnable simply with cargo test without the fear of too many CPUs overusing the memory.
  • Close Unused import warnings #624
  • Use --all-targets with clippy. Also use --workspace as replacement for the apparently deprecated --all.
  • Add a cargo check to check parts of code not used by cargo build --release
  • Remove unused bench
  • Separate testing code from production code
    • In integration tests, not relying on features of other workspace crates, except for test_utils
  • Use different BackgroundDevnet command depending on testing environment:
    • If local, same as it was
    • If CircleCI, rely on the pre-compiled binary.
  • In BackgroundDevnet spawnng, extend max retries from 20 to 40 (10 seconds to 20).
  • Replace crate netstat2 with listeners - otherwise doesn't compile on @marioiordanov's computer

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC mentioned this pull request Dec 23, 2024
10 tasks
@FabijanC
Copy link
Contributor Author

Currently experiencing race condition in tests. #666 should resolve the issue.

@FabijanC FabijanC changed the title Fix test org Improve integration testing (file organization, time, memory) Dec 23, 2024
@FabijanC FabijanC mentioned this pull request Jan 2, 2025
@FabijanC FabijanC marked this pull request as ready for review January 7, 2025 15:57
@FabijanC FabijanC requested a review from marioiordanov January 7, 2025 16:01
@FabijanC FabijanC merged commit 8f758f8 into main Jan 8, 2025
1 check passed
@FabijanC FabijanC deleted the fix-test-org branch January 8, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused import warnings CI workflow sometimes overuses memory
2 participants